Improve MemoryStorage read and add dump for verilog-compliant memory files #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in random generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
The
loadMemHexfunction onMemoryStoragewas overly restrictive. This PR deprecates it and replaces it withloadMemString, which also accepts arguments forradixandbitsPerAddress. Additionally, this PR adds adumpMemStringwhich also supportsradixandbitsPerAddress.Related Issue(s)
This PR builds upon #175 (though it's not really related), so that one should go in first.
Fix #174
Testing
Added new tests, kept old tests to make sure nothing broke.
Backwards-compatibility
No, just deprecation
Documentation
Yes, docs updated and API docs include more information about how to use the new functionality.